Re: [PATCH v2 01/13] trinity: Add base driver

From: Jiho Chu
Date: Mon Sep 19 2022 - 00:26:29 EST


On Sat, 17 Sep 2022 09:41:13 +0200
"Arnd Bergmann" <arnd@xxxxxxxx> wrote:

>
> > +
> > +#ifndef TASK_COMM_LEN
> > +#define TASK_COMM_LEN 16
> > +#endif
> > +
> > +#define TRINITY_APP_NAME_MAX TASK_COMM_LEN
> > +#define TRINITY_APP_STAT_MAX 10
> > +#define TRINITY_REQ_STAT_MAX 10
>
> The structure layout should not depend on whether an application
> has included a header that defines TASK_COMM_LEN.
>
> What is the purpose of including an application name here?
>

I agree. TASK_COMM_LEN will be removed.
app_name is current context's execuable name, and it's used for
per-app NPU statistics info.

Thanks,
Jiho Chu