Re: [PATCH] ARM: shmobile: Kconfig: Drop selecting SOC_BUS

[Lad, Prabhakar]

Hi Geert,

Thank you for the review.

On Sun, Sep 18, 2022 at 10:32 AM Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
>
> Hi Prabhakar,
>
> On Fri, Sep 16, 2022 at 1:39 AM Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> >
> > Don't automatically select the SOC_BUS config option as we already have
> > automatically selected it as part of the SOC_RENESAS config option [0]
> > as renesas-soc.c [1] uses the APIs provided by SOC_BUS config option.
> >
> > [0] drivers/soc/renesas/Kconfig
> > [1] drivers/soc/renesas/renesas-soc.c
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> i.e. will queue in renesas-devel for v6.1.
>
> > --- a/arch/arm/mach-shmobile/Kconfig
> > +++ b/arch/arm/mach-shmobile/Kconfig
> > @@ -6,5 +6,4 @@ menuconfig ARCH_RENESAS
> >         select GPIOLIB
> >         select NO_IOPORT_MAP
> >         select PINCTRL
> > -       select SOC_BUS
> >         select ZONE_DMA if ARM_LPAE
>
> Nice catch!
> I guess it would make sense to move the GPIOLIB and PINCTRL selects
> to drivers/soc/renesas/Kconfig, too, as they are needed for all
> (arm32/arm64/riscv) Renesas SoCs?
>
Agreed, shall I move them under SOC_RENESAS?

Cheers,
Prabhakar