Re: [PATCH] arm64: dts: renesas: rzg2ul-smarc-som: Drop enabling wdt2

From: Geert Uytterhoeven
Date: Mon Sep 19 2022 - 06:10:55 EST


Hi Biju,

On Mon, Sep 19, 2022 at 12:06 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> > On Sun, Sep 18, 2022 at 10:04 AM Geert Uytterhoeven <geert@linux-
> > m68k.org> wrote:
> > > On Wed, Sep 14, 2022 at 3:43 PM Prabhakar
> > <prabhakar.csengg@xxxxxxxxx> wrote:
> > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > > >
> > > > WDT CH2 is specifically to check the operation of Cortex-M33 CPU
> > so
> > > > don't enable WDT2 by default.
> > > >
> > For consistency I'll drop enabling WDT2 from the RZ/G2L{C} too.
>
> Does remove unused clocks turn off WDT2 clock during late init??
>
> If that is the case, we should remove entries from clock table as well?

Or add it to *_crit_mod_clks[]?

Note that drivers/clk/renesas/r9a07g043-cpg.c creates wdt2 clocks
and resets, so that should probably be moved inside the #ifdef
CONFIG_ARM64 section.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds