Re: [PATCH -next v2 1/5] docs: notifier-error-inject: fix non-working usage of negative values

[David Hildenbrand]

On 19.09.22 11:01, zhaogongyi wrote:
> Hi!
>
> > On 17.09.22 07:39, Akinobu Mita wrote:
> > > 2022年9月15日(木) 18:01 Zhao Gongyi <zhaogongyi@xxxxxxxxxx>:
> > > > Fault injection uses debugfs in a way that the provided values via
> > > > sysfs are interpreted as u64. Providing negative numbers results in
> > > > an error:
> > > >
> > > >     # cd sys/kernel/debug/notifier-error-inject/memory
> > > >     #  echo -12 > actions/MEM_GOING_ONLINE/error
> > > >     -bash: echo: write error: Invalid argument
> > > >
> > > > Update the docs and examples to use "printf %#x <val>" in these cases.
> > >
> > > I'd rather fix the notifier-error-inject module than change the user
> > interface.
> > > I'll send a patch, so could you check if that solves the problem.
> >
> > That will also make patch #2 unnecessary, correct?
>
> Yes. But there is another commit 005747526d4f3c2ec995891e95cb7625161022f9 that has the same problem.
>
> Thanks!

Right. See my reply to the other patch:

https://lkml.kernel.org/r/93c044ca-7d2f-e23f-8eb4-72c133737a15@xxxxxxxxxx

simple_attr_read()/simple_attr_write() fmt behavior is odd.

--
Thanks,

David / dhildenb