Re: [PATCH V3 04/11] um: Improve panic notifiers consistency and ordering
From: Guilherme G. Piccoli
Date: Mon Sep 19 2022 - 07:45:39 EST
On 18/09/2022 18:19, Richard Weinberger wrote:
> ----- Ursprüngliche Mail -----
>> Von: "Guilherme G. Piccoli" <gpiccoli@xxxxxxxxxx>
>> On 19/08/2022 19:17, Guilherme G. Piccoli wrote:
>>> Currently the panic notifiers from user mode linux don't follow
>>> the convention for most of the other notifiers present in the
>>> kernel (indentation, priority setting, numeric return).
>>> More important, the priorities could be improved, since it's a
>>> special case (userspace), hence we could run the notifiers earlier;
>>> user mode linux shouldn't care much with other panic notifiers but
>>> the ordering among the mconsole and arch notifier is important,
>>> given that the arch one effectively triggers a core dump.
>>>
>>> Fix that by running the mconsole notifier as the first panic
>>> notifier, followed by the architecture one (that coredumps).
>>>
>>> Cc: Anton Ivanov <anton.ivanov@xxxxxxxxxxxxxxxxxx>
>>> Cc: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
>>> Cc: Richard Weinberger <richard@xxxxxx>
>>> Signed-off-by: Guilherme G. Piccoli <gpiccoli@xxxxxxxxxx>
>>>
>>> V3:
>>> - No changes.
>>> [...]
>>
>> Hi Johannes, sorry for the ping. Do you think you could pick this one?
>> Or if you prefer, I can resend it alone (not in the series) - let me
>> know your preference.
>
> This patch is on my TODO list.
> Just had no chance to test it.
>
> Thanks,
> //richard
Thanks a lot Richard!