Re: [PATCH net-next v2 3/5] net: mediatek: sgmii: mtk_pcs_setup_mode_an: don't rely on register defaults

From: Alexander 'lynxis' Couzens
Date: Mon Sep 19 2022 - 09:43:18 EST


On Mon, 19 Sep 2022 12:29:34 +0100
"Russell King (Oracle)" <linux@xxxxxxxxxxxxxxx> wrote:

> I'm not sure if I've asked this before, but why does SGMII_AN_RESTART
> need to be set here? It could do with a comment in the code.

It's not my bit :). I've not added it. But why not (re)start autoneg
when powering up the phy?

Should it done elsewhere?