Re: [PATCHv3 12/14] regulator: expose regmap_find_closest_bigger

[Sebastian Reichel]

Hi,

On Sat, Sep 10, 2022 at 08:17:09PM +0300, Matti Vaittinen wrote:
> pe 9. syysk. 2022 klo 21.21 Sebastian Reichel
> (sebastian.reichel@xxxxxxxxxxxxx) kirjoitti:
> >
> > Expose and document the table lookup logic used by
> > regulator_set_ramp_delay_regmap, so that it can be
> > reused for devices that cannot be configured via
> > regulator_set_ramp_delay_regmap.
> >
> 
> I am always in favor of adding helpers to be used for common tasks. I
> am not demanding this (so please ignore my comment if you feel so) but
> I guess finding the "closest bigger" from a table is not ramp-delay or
> even regulator specific. I believe something like this might live
> under lib - if exported.

I'm bad with naming :) If you or Mark have a specific suggestion I
can change it accordingly.

> Anyways, and whatever it is worth:
> Acked-by: Matti Vaittinen <matti.vaittinen@mazziesaccount@xxxxxxxxx>
> for exporting such a helper. (Or please disregard the ack if acks are
> reserved only for maintainers - It's just a sign that I think this is
> a good idea [even if it could live in lib])

I usually use 'Reviewed-by: <...>' in that case. But your Acked
line is broken. Looks like you have split personality problem
between work and private mail account :)

-- Sebastian

Attachment: signature.asc
Description: PGP signature