Re: [PATCH 1/2] mtd: rawnand: stm32_fmc2: Fix dma_map_sg error check

[Miquel Raynal]

Hi Jack,

jinpu.wang@xxxxxxxxx wrote on Thu, 25 Aug 2022 09:53:37 +0200:

> dma_map_sg return 0 on error, in case of error return -EIO.
> 
> Cc: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> Cc: Richard Weinberger <richard@xxxxxx>
> Cc: Vignesh Raghavendra <vigneshr@xxxxxx>
> Cc: Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx>
> Cc: Alexandre Torgue <alexandre.torgue@xxxxxxxxxxx>
> Cc: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> Cc: Christophe Kerello <christophe.kerello@xxxxxxxxxxx>
> Cc: Cai Huoqing <cai.huoqing@xxxxxxxxx>
> Cc: linux-mtd@xxxxxxxxxxxxxxxxxxx
> Cc: linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Fixes: 2cd457f328c1 ("mtd: rawnand: stm32_fmc2: add STM32 FMC2 NAND flash controller driver")
> Signed-off-by: Jack Wang <jinpu.wang@xxxxxxxxx>

I'll apply this series so I need to re-add Christophe's tag sent on the
patch alone (which is identical as far as I see):

Reviewed-by: Christophe Kerello <christophe.kerello@xxxxxxxxxxx>

> ---
>  drivers/mtd/nand/raw/stm32_fmc2_nand.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c
> index 87c1c7dd97eb..a0c825af19fa 100644
> --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c
> +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c
> @@ -862,8 +862,8 @@ static int stm32_fmc2_nfc_xfer(struct nand_chip *chip, const u8 *buf,
>  
>  	ret = dma_map_sg(nfc->dev, nfc->dma_data_sg.sgl,
>  			 eccsteps, dma_data_dir);
> -	if (ret < 0)
> -		return ret;
> +	if (!ret)
> +		return -EIO;
>  
>  	desc_data = dmaengine_prep_slave_sg(dma_ch, nfc->dma_data_sg.sgl,
>  					    eccsteps, dma_transfer_dir,
> @@ -893,8 +893,10 @@ static int stm32_fmc2_nfc_xfer(struct nand_chip *chip, const u8 *buf,
>  
>  		ret = dma_map_sg(nfc->dev, nfc->dma_ecc_sg.sgl,
>  				 eccsteps, dma_data_dir);
> -		if (ret < 0)
> +		if (!ret) {
> +			ret = -EIO;
>  			goto err_unmap_data;
> +		}
>  
>  		desc_ecc = dmaengine_prep_slave_sg(nfc->dma_ecc_ch,
>  						   nfc->dma_ecc_sg.sgl,


Thanks,
Miquèl