RE: [EXT] Re: [PATCH v11 5/6] PCI: endpoint: cleanup pci-epf-vntb.c

[Frank Li]

> -----Original Message-----
> From: Bjorn Helgaas <helgaas@xxxxxxxxxx>
> Sent: Monday, September 19, 2022 12:03 PM
> To: Frank Li <frank.li@xxxxxxx>
> Cc: maz@xxxxxxxxxx; tglx@xxxxxxxxxxxxx; robh+dt@xxxxxxxxxx;
> krzysztof.kozlowski+dt@xxxxxxxxxx; shawnguo@xxxxxxxxxx;
> s.hauer@xxxxxxxxxxxxxx; kw@xxxxxxxxx; bhelgaas@xxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx; Peng Fan
> <peng.fan@xxxxxxx>; Aisheng Dong <aisheng.dong@xxxxxxx>;
> jdmason@xxxxxxxx; kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; dl-linux-
> imx <linux-imx@xxxxxxx>; kishon@xxxxxx; lorenzo.pieralisi@xxxxxxx;
> ntb@xxxxxxxxxxxxxxx; lznuaa@xxxxxxxxx; imx@xxxxxxxxxxxxxxx;
> manivannan.sadhasivam@xxxxxxxxxx
> Subject: [EXT] Re: [PATCH v11 5/6] PCI: endpoint: cleanup pci-epf-vntb.c
> 
> Caution: EXT Email
> 
> In subject (I mentioned this last time, too):
> 
>   PCI: endpoint: pci-epf-vntb: Clean up
> 
> On Mon, Sep 19, 2022 at 10:40:37AM -0500, Frank Li wrote:
> > Remove unused field: epf_db_phy.
> > Remove __iomem before epf_db.
> > Change epf_db to u32* from void *
> > Remove dupicate check if (readl(ntb->epf_db + i * 4)).
> 
> s/dupicate/duplicate/
> 
> > Using sizeof(u32) instead of number 4 at all place.
> >
> > Clean up sparse build warning
> >   Using  epf_db[i] instead of readl() because epf_db is located in local
> memory
> >   and allocated by dma_alloc_coherent()
> 
> Is "Using epf_db[i] ..." an sparse warning?  The indentation suggests
> that it is, but it doesn't seem related.

[Frank Li] sparse warning about __IOMEM.  Dma_alloc_conherece()
Return void *.  Not void __IOMEM *.  

Readl() use void __IOMEM *. 

Epf_db[i] is more simple and have not memory order risk here.    

> 
> > Replace pci_epc_mem_free_addr() with pci_epf_free_space() at error
> handle path
> > to match pci_epf_alloc_space().
> >
> > Cleanup warning found by scripts/kernel-doc
> > Fix indentation of the struct epf_ntb_ctrl
> > Consildate term
> 
> s/Consildate/Consolidate/
> 
> >   host, host1 to HOST
> >   vhost, vHost, Vhost, VHOST2 to VHOST