Re: [PATCH] arm64: dts: marvell: Fix compatible strings for Armada 3720 boards
From: Pali Rohár
Date: Mon Sep 19 2022 - 19:20:15 EST
On Saturday 03 September 2022 00:31:10 Pali Rohár wrote:
> On Monday 08 August 2022 22:33:30 Andrew Lunn wrote:
> > On Mon, Aug 08, 2022 at 10:24:56PM +0200, Pali Rohár wrote:
> > > PING?
> >
> > It is too late for the merge window.
>
> So, now for the next?
PING?
> > > > diff --git a/arch/arm64/boot/dts/marvell/armada-372x.dtsi b/arch/arm64/boot/dts/marvell/armada-372x.dtsi
> > > > index 5ce55bdbb995..02ae1e153288 100644
> > > > --- a/arch/arm64/boot/dts/marvell/armada-372x.dtsi
> > > > +++ b/arch/arm64/boot/dts/marvell/armada-372x.dtsi
> > > > @@ -13,7 +13,7 @@
> > > >
> > > > / {
> > > > model = "Marvell Armada 3720 SoC";
> > > > - compatible = "marvell,armada3720", "marvell,armada3710";
> > > > + compatible = "marvell,armada3720", "marvell,armada3700";
> >
> > Does it make sense to have a compatible here? The board .dts should
> > provide it. And if the board does not provide it, we probably want the
> > board to not boot because it does not have a compatible.
> >
> > Andrew