Re: [PATCH v4 02/10] tty: serial: clean up stop-tx part in altera_uart_tx_chars()

From: Ilpo Järvinen
Date: Tue Sep 20 2022 - 04:07:39 EST


On Tue, 20 Sep 2022, Jiri Slaby wrote:

> The "stop TX" path in altera_uart_tx_chars() is open-coded, so:
> * use uart_circ_empty() to check if the buffer is empty, and
> * when true, call altera_uart_stop_tx().
>
> Cc: Tobias Klauser <tklauser@xxxxxxxxxx>
> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>

--
i.