Re: [PATCH v2 08/44] cpuidle,imx6: Push RCU-idle into driver
From: Frederic Weisbecker
Date: Tue Sep 20 2022 - 05:02:08 EST
On Tue, Sep 20, 2022 at 10:58:59AM +0200, Peter Zijlstra wrote:
> On Mon, Sep 19, 2022 at 04:21:23PM +0200, Frederic Weisbecker wrote:
> > On Mon, Sep 19, 2022 at 11:59:47AM +0200, Peter Zijlstra wrote:
> > > Doing RCU-idle outside the driver, only to then temporarily enable it
> > > again, at least twice, before going idle is daft.
> >
> > Hmm, what ends up calling RCU_IDLE() here? Also what about
> > cpu_do_idle()?
>
> I've ammended patches 5-12 with a comment like:
>
> Notably both cpu_pm_enter() and cpu_cluster_pm_enter() implicity
> re-enable RCU.
>
> (each noting the specific sites for the relevant patch).
Thanks!