Re: [PATCH v4 06/13] ACPI: resources: Add wake_capable parameter to acpi_dev_irq_flags
From: Andy Shevchenko
Date: Tue Sep 20 2022 - 08:35:57 EST
On Mon, Sep 19, 2022 at 09:59:08AM -0600, Raul E Rangel wrote:
> ACPI IRQ/Interrupt resources contain a bit that describes if the
> interrupt should wake the system. This change exposes that bit via
> a new IORESOURCE_IRQ_WAKECAPABLE flag. Drivers should check this flag
> before arming an IRQ to wake the system.
(A nit-pick, but because of other patch comment)
...
> - acpi_dev_get_irqresource(res, ext_irq->interrupts[index],
> - ext_irq->triggering, ext_irq->polarity,
> - ext_irq->shareable, false);
> + acpi_dev_get_irqresource(res,
> + ext_irq->interrupts[index],
> + ext_irq->triggering,
> + ext_irq->polarity,
> + ext_irq->shareable,
> + ext_irq->wake_capable,
> + false);
I understand this is done by a script, but it's unrelated indentation changes,
please just change what is related, like:
- ext_irq->shareable, false);
+ ext_irq->shareable, ext_irq->wake_capable,
+ false);
--
With Best Regards,
Andy Shevchenko