Re: [PATCH] drm/amdgpu: initialize r variable into amdgpu_cs_submit function

[Christian König]

Am 20.09.22 um 14:32 schrieb Tommaso Merciai:
> Hi Christian,
>
> On Tue, Sep 20, 2022 at 02:23:58PM +0200, Christian König wrote:
> > Am 20.09.22 um 14:22 schrieb Tommaso Merciai:
> > > The builds of arm64 allmodconfig with clang failed to build
> > > next-20220920 with the following result:
> > >
> > > 1190:3: error: variable 'r' is uninitialized when used here [-Werror,-Wuninitialized]
> > > note: initialize the variable 'r' to silence this warning
> > >
> > > This fix compilation error
> > I've already send a patch to fix this to the mailing list 7 Minutes ago :)
> >
> > Please review or ack that one.
> Sorry, my bad. Don't see your patch :)

No problem, already reviewed and pushed :)

It probably takes a moment for the mailing list to deliver the patch to 
everybody.

Cheers,
Christian.

> Cheers,
> Tommaso
>
> > Thanks,
> > Christian.
> >
> > > Signed-off-by: Tommaso Merciai <tommaso.merciai@xxxxxxxxxxxxxxxxxxxx>
> > > ---
> > >    drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +-
> > >    1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> > > index 58088c663125..efa3dc9b69fd 100644
> > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> > > @@ -1168,7 +1168,7 @@ static int amdgpu_cs_submit(struct amdgpu_cs_parser *p,
> > >    	struct amdgpu_bo_list_entry *e;
> > >    	struct amdgpu_job *job;
> > >    	uint64_t seq;
> > > -	int r;
> > > +	int r = 0;
> > >    	job = p->job;
> > >    	p->job = NULL;