Re: [PATCH v3] pinctrl: ocelot: Fix interrupt controller

From: Michael Walle
Date: Tue Sep 20 2022 - 10:25:59 EST


Am 2022-09-20 14:34, schrieb Michael Walle:
Am 2022-09-20 14:28, schrieb Linus Walleij:

Just checking: since these drivers obviously must pass pass
IRQF_SHARED, have you also made sure that each driver also
will properly return IRQ_HANDLED if the interrupt was for them
(triggered by "their" hardware) but IRQ_NONE if the interrupt was
not for them (triggered by something else)?

Thanks, I'll check it.

The gpy driver seems to handle that correctly. The micrel one introduced
a regression some time ago. I've send a fix in the meantime [1], but it
doesn't help for the multiple interrupts here.

-michael

[1] https://lore.kernel.org/netdev/20220920141619.808117-1-michael@xxxxxxxx/