Re: [PATCH] arm64: dts: mediatek: mt8183: remove thermal zones without trips.

From: Amjad Ouled-Ameur
Date: Tue Sep 20 2022 - 11:17:40 EST


Hi,

On 9/15/22 17:50, Daniel Lezcano wrote:
On 14/09/2022 16:15, Matthias Brugger wrote:


On 14/09/2022 15:13, Amjad Ouled-Ameur wrote:
Thermal zones without trip point are not registered by thermal core.

tzts1 ~ tzts6 zones of mt8183 were intially introduced for test-purpose
only but are not supposed to remain on DT.

Remove the zones above and keep only cpu_thermal.


My understanding is that this thermal zones exist but are not used. DTS should describe the HW as it is, so I propose to add
status = "disabled";
to the zones.


At least the trip points must be declared as stated in the bindings

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/thermal/thermal-zones.yaml#n213

In the base case we should but there are no trip points for these sensors according to MediaTek.


Regards,

Amjad