Re: [net-next v8 2/3] net: ethernet: adi: Add ADIN1110 support

From: Jakub Kicinski
Date: Tue Sep 20 2022 - 11:29:19 EST


On Tue, 13 Sep 2022 15:26:28 +0300 andrei.tachici@xxxxxxxxxxxxxxx wrote:
> +static int adin1110_port_get_port_parent_id(struct net_device *dev,
> + struct netdev_phys_item_id *ppid)
> +{
> + struct adin1110_port_priv *port_priv = netdev_priv(dev);
> + struct adin1110_priv *priv = port_priv->priv;
> +
> + ppid->id_len = strnlen(priv->mii_bus_name, MII_BUS_ID_SIZE);
> + memcpy(ppid->id, priv->mii_bus_name, ppid->id_len);

gcc 8.5 complains about overflow here, MII_BUS_ID_SIZE is larger
than MAX_PHYS_ITEM_ID_LEN, i.e. the length of ppid->id.

Please fix this up, the build bots are gonna get angry.