Re: [PATCH v3 0/4] dirty_log_perf_test cpu pinning and some goodies
From: Vipin Sharma
Date: Tue Sep 20 2022 - 12:32:05 EST
On Fri, Aug 26, 2022 at 11:45 AM Vipin Sharma <vipinsh@xxxxxxxxxx> wrote:
>
> Pin vcpus to a host physical cpus in dirty_log_perf_test and optionally
> pin the main application thread to a physical cpu if provided. All tests
> based on perf_test_util framework can take advantage of it if needed.
>
> While at it, I changed atoi() to atoi_paranoid() in other tests, sorted
> command line options alphabetically, and made switch case logic of -e
> option less error prone to code changes by adding break and decoupling
> it from -g.
>
> v3:
> - Moved atoi_paranoid() to test_util.c and replaced all atoi() usage
> with atoi_paranoid()
> - Sorted command line options alphabetically.
> - Instead of creating a vcpu thread on a specific pcpu the thread will
> migrate to the provided pcpu after its creation.
> - Decoupled -e and -g option.
>
> v2: https://lore.kernel.org/lkml/20220819210737.763135-1-vipinsh@xxxxxxxxxx/
> - Removed -d option.
> - One cpu list passed as option, cpus for vcpus, followed by
> application thread cpu.
> - Added paranoid cousin of atoi().
>
> v1: https://lore.kernel.org/lkml/20220817152956.4056410-1-vipinsh@xxxxxxxxxx
>
> Vipin Sharma (4):
> KVM: selftests: Explicitly set variables based on options in
> dirty_log_perf_test
> KVM: selftests: Put command line options in alphabetical order in
> dirty_log_perf_test
> KVM: selftests: Add atoi_paranoid to catch errors missed by atoi
> KVM: selftests: Run dirty_log_perf_test on specific cpus
>
> .../selftests/kvm/aarch64/arch_timer.c | 8 +--
> .../testing/selftests/kvm/aarch64/vgic_irq.c | 6 +-
> .../selftests/kvm/access_tracking_perf_test.c | 2 +-
> .../selftests/kvm/demand_paging_test.c | 2 +-
> .../selftests/kvm/dirty_log_perf_test.c | 65 +++++++++++++------
> .../selftests/kvm/include/perf_test_util.h | 4 ++
> .../testing/selftests/kvm/include/test_util.h | 2 +
> .../selftests/kvm/kvm_page_table_test.c | 2 +-
> .../selftests/kvm/lib/perf_test_util.c | 62 +++++++++++++++++-
> tools/testing/selftests/kvm/lib/test_util.c | 14 ++++
> .../selftests/kvm/max_guest_memory_test.c | 6 +-
> .../kvm/memslot_modification_stress_test.c | 4 +-
> .../testing/selftests/kvm/memslot_perf_test.c | 10 +--
> .../selftests/kvm/set_memory_region_test.c | 2 +-
> .../selftests/kvm/x86_64/nx_huge_pages_test.c | 4 +-
> 15 files changed, 148 insertions(+), 45 deletions(-)
>
> --
> 2.37.2.672.g94769d06f0-goog
>
Knock Knock!!