Re: [PATCH v1] net/ethtool/tunnels: check the return value of nla_nest_start()

[Li Zhong]

On Tue, Sep 20, 2022 at 11:37 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Fri, 16 Sep 2022 19:26:02 -0700 Li Zhong wrote:
> >                       goto err_cancel_table;
> >
> >               entry = nla_nest_start(skb, ETHTOOL_A_TUNNEL_UDP_TABLE_ENTRY);
> > +             if (!entry)
> > +                     return -EMSGSIZE;
>
> not even correct, and completely harmless

Thanks for your reply. Maybe a more suitable way of error handling is 'goto
err_cancel_table;'?