Re: [PATCH net-next 05/13] sunhme: Regularize probe errors
From: Jakub Kicinski
Date: Tue Sep 20 2022 - 15:36:52 EST
On Sun, 18 Sep 2022 19:26:18 -0400 Sean Anderson wrote:
> - err = -ENODEV;
> + err = -EINVAL;
> if ((pci_resource_flags(pdev, 0) & IORESOURCE_IO) != 0) {
> printk(KERN_ERR "happymeal(PCI): Cannot find proper PCI device base address.\n");
> goto err_out_clear_quattro;
> }
Why not move it inside the if?