Re: [PATCH v2 net-next 7/7] net/sched: taprio: replace safety precautions with comments

From: Jakub Kicinski
Date: Tue Sep 20 2022 - 17:01:33 EST


On Thu, 15 Sep 2022 13:50:46 +0300 Vladimir Oltean wrote:
> The WARN_ON_ONCE() checks introduced in commit 13511704f8d7 ("net:
> taprio offload: enforce qdisc to netdev queue mapping") take a small
> toll on performance, but otherwise, the conditions are never expected to
> happen. Replace them with comments, such that the information is still
> conveyed to developers.

Another option is DEBUG_NET_WARN_ON_ONCE() FWIW, you probably know..