Re: [PATCH v2] HID: nintendo: check analog user calibration for plausibility

From: Daniel Ogorchock
Date: Tue Sep 20 2022 - 18:07:02 EST


> static const u16 DFLT_STICK_CAL_CEN = 2000;
> static const u16 DFLT_STICK_CAL_MAX = 3500;
> static const u16 DFLT_STICK_CAL_MIN = 500;
> +static void joycon_use_default_calibration(struct joycon_ctlr *ctlr,
> + struct joycon_stick_cal *cal_x,
> + struct joycon_stick_cal *cal_y,
> + const char *stick, int ret)
> +{
> + hid_warn(ctlr->hdev,
> + "Failed to read %s stick cal, "
> + "using defaults; e=%d\n",
> + stick, ret);
> +

Sorry, missed this on my first readthrough. I think the coding style
mentions not to break up the logged string into multiple lines, since
it'll harm greppability.

-Daniel