Re: [PATCH v1 2/2] media: uvcvideo: Use standard names for menus

From: kernel test robot
Date: Tue Sep 20 2022 - 18:41:59 EST


Hi Ricardo,

I love your patch! Perhaps something to improve:

[auto build test WARNING on 521a547ced6477c54b4b0cc206000406c221b4d6]

url: https://github.com/intel-lab-lkp/linux/commits/Ricardo-Ribalda/media-uvc-Get-menu-names-from-framework/20220920-221725
base: 521a547ced6477c54b4b0cc206000406c221b4d6
config: i386-randconfig-a015 (https://download.01.org/0day-ci/archive/20220921/202209210616.5XZvYu7j-lkp@xxxxxxxxx/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/6f853c5bf3837302050a20e9142196ccb12a2918
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Ricardo-Ribalda/media-uvc-Get-menu-names-from-framework/20220920-221725
git checkout 6f853c5bf3837302050a20e9142196ccb12a2918
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/media/usb/uvc/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/media/usb/uvc/uvc_driver.c:2664:35: warning: unused variable 'power_line_frequency_controls_limited' [-Wunused-const-variable]
static const struct uvc_menu_info power_line_frequency_controls_limited[] = {
^
1 warning generated.


vim +/power_line_frequency_controls_limited +2664 drivers/media/usb/uvc/uvc_driver.c

310fe52461e6244 drivers/media/video/uvc/uvc_driver.c Laurent Pinchart 2009-12-09 2659
c0efd232929c2cd drivers/media/video/uvc/uvc_driver.c Laurent Pinchart 2008-06-30 2660 /* ------------------------------------------------------------------------
c0efd232929c2cd drivers/media/video/uvc/uvc_driver.c Laurent Pinchart 2008-06-30 2661 * Driver initialization and cleanup
c0efd232929c2cd drivers/media/video/uvc/uvc_driver.c Laurent Pinchart 2008-06-30 2662 */
c0efd232929c2cd drivers/media/video/uvc/uvc_driver.c Laurent Pinchart 2008-06-30 2663
382075604a688b9 drivers/media/usb/uvc/uvc_driver.c Ricardo Ribalda 2022-06-07 @2664 static const struct uvc_menu_info power_line_frequency_controls_limited[] = {
382075604a688b9 drivers/media/usb/uvc/uvc_driver.c Ricardo Ribalda 2022-06-07 2665 { 1, "50 Hz" },
382075604a688b9 drivers/media/usb/uvc/uvc_driver.c Ricardo Ribalda 2022-06-07 2666 { 2, "60 Hz" },
382075604a688b9 drivers/media/usb/uvc/uvc_driver.c Ricardo Ribalda 2022-06-07 2667 };
382075604a688b9 drivers/media/usb/uvc/uvc_driver.c Ricardo Ribalda 2022-06-07 2668

--
0-DAY CI Kernel Test Service
https://01.org/lkp