Re: [PATCH net-next 1/2] udp: Refactor udp_read_skb()
From: Peilin Ye
Date: Tue Sep 20 2022 - 21:05:35 EST
On Tue, Sep 20, 2022 at 05:40:52PM -0700, Jakub Kicinski wrote:
> On Tue, 20 Sep 2022 17:38:59 -0700 Jakub Kicinski wrote:
> > On Wed, 14 Sep 2022 01:15:30 -0700 Peilin Ye wrote:
> > > Delete the unnecessary while loop in udp_read_skb() for readability.
> > > Additionally, since recv_actor() cannot return a value greater than
> > > skb->len (see sk_psock_verdict_recv()), remove the redundant check.
> >
> > These don't apply cleanly, please rebase?
>
> Ah, it's the WARN_ON_ONCE() change. In that case please resend after
> net is merged into net-next (Thu evening).
Sure, but only the TCP part was merged [1] into net. I just sent the
UDP part again [2], and will resend this patchset after both [1] and [2]
are merged into net-next. Thanks!
[1] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=96628951869c0dedf0377adca01c8675172d8639
[2] https://lore.kernel.org/netdev/20220921005915.2697-1-yepeilin.cs@xxxxxxxxx/T/#u
Peilin Ye