Re: [PATCH 1/2] dt-bindings: net: mediatek-dwmac: add support for mt8188

From: Jianguo Zhang
Date: Tue Sep 20 2022 - 21:15:15 EST


Dear AngeloGioacchino

Thanks for your comment.

On Tue, 2022-09-20 at 15:22 +0200, AngeloGioacchino Del Regno wrote:
> Il 20/09/22 10:36, Jianguo Zhang ha scritto:
> > Add binding document for the ethernet on mt8188
> >
> > Signed-off-by: Jianguo Zhang <jianguo.zhang@xxxxxxxxxxxx>
> > ---
> > .../devicetree/bindings/net/mediatek-dwmac.yaml | 10
> > ++++++++--
> > 1 file changed, 8 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/mediatek-
> > dwmac.yaml b/Documentation/devicetree/bindings/net/mediatek-
> > dwmac.yaml
> > index 61b2fb9e141b..eaf7e8d53432 100644
> > --- a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
> > +++ b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
> > @@ -20,6 +20,7 @@ select:
> > enum:
> > - mediatek,mt2712-gmac
>
> Please keep the list ordered by name. MT8188 goes before 8195.
>
We will adjust the order in next version patches.

> > - mediatek,mt8195-gmac
> > + - mediatek,mt8188-gmac
> > required:
> > - compatible
> >
> > @@ -37,6 +38,11 @@ properties:
> > - enum:
> > - mediatek,mt8195-gmac
> > - const: snps,dwmac-5.10a
> > + - items:
> > + - enum:
> > + - mediatek,mt8188-gmac
> > + - const: mediatek,mt8195-gmac
> > + - const: snps,dwmac-5.10a
> >
> > clocks:
> > minItems: 5
> > @@ -74,7 +80,7 @@ properties:
> > or will round down. Range 0~31*170.
> > For MT2712 RMII/MII interface, Allowed value need to be a
> > multiple of 550,
> > or will round down. Range 0~31*550.
> > - For MT8195 RGMII/RMII/MII interface, Allowed value need to
> > be a multiple of 290,
> > + For MT8195/MT8188 RGMII/RMII/MII interface, Allowed value
> > need to be a multiple of 290,
>
> For MT8188/MT8195
>
We will adjust the order in next version patches.

> > or will round down. Range 0~31*290.
> >
> > mediatek,rx-delay-ps:
> > @@ -84,7 +90,7 @@ properties:
> > or will round down. Range 0~31*170.
> > For MT2712 RMII/MII interface, Allowed value need to be a
> > multiple of 550,
> > or will round down. Range 0~31*550.
> > - For MT8195 RGMII/RMII/MII interface, Allowed value need to
> > be a multiple
> > + For MT8195/MT8188 RGMII/RMII/MII interface, Allowed value
> > need to be a multiple
>
> For MT8188/MT8195
>
We will adjust the order in next version patches.

> > of 290, or will round down. Range 0~31*290.
> >
> > mediatek,rmii-rxc:
>
>
BRS
Jianguo