Re: [tip: perf/core] perf/core: Convert snprintf() to scnprintf()

From: Peter Zijlstra
Date: Wed Sep 21 2022 - 04:34:48 EST


On Wed, Sep 21, 2022 at 08:08:55AM -0000, tip-bot2 for Jules Irenge wrote:
> The following commit has been merged into the perf/core branch of tip:
>
> Commit-ID: 678739d622ae7b75b62d550858b6bf104c43e2df
> Gitweb: https://git.kernel.org/tip/678739d622ae7b75b62d550858b6bf104c43e2df
> Author: Jules Irenge <jbi.octave@xxxxxxxxx>
> AuthorDate: Sun, 18 Sep 2022 00:41:08 +01:00
> Committer: Ingo Molnar <mingo@xxxxxxxxxx>
> CommitterDate: Wed, 21 Sep 2022 10:01:20 +02:00
>
> perf/core: Convert snprintf() to scnprintf()
>
> Coccinelle reports a warning:
>
> WARNING: use scnprintf or sprintf
>
> Adding to that, there has also been some slow migration from snprintf to scnprintf.
>
> This LWN article explains the rationale for this change:
>
> https: //lwn.net/Articles/69419/
>
> No change in behavior.
>
> [ mingo: Improved the changelog. ]

And yet, at this point I still have no clue what's wrong with
snprintf(). So not much improvement :/

As such I'm still very much against this patch.