Re: [PATCH v4 0/6] Define EINVAL as device/domain incompatibility

From: Jean-Philippe Brucker
Date: Wed Sep 21 2022 - 04:55:26 EST


On Wed, Sep 21, 2022 at 01:22:31AM -0700, Nicolin Chen wrote:
> This series is to replace the previous EMEDIUMTYPE patch in a VFIO series:
> https://lore.kernel.org/kvm/Yxnt9uQTmbqul5lf@xxxxxxxxxx/
>
> The purpose is to regulate all existing ->attach_dev callback functions to
> use EINVAL exclusively for an incompatibility error between a device and a
> domain. This allows VFIO and IOMMUFD to detect such a soft error, and then
> try a different domain with the same device.
[...]
> drivers/iommu/amd/iommu.c | 12 +----
> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 11 +---
> drivers/iommu/arm/arm-smmu/arm-smmu.c | 3 --
> drivers/iommu/arm/arm-smmu/qcom_iommu.c | 7 +--
> drivers/iommu/fsl_pamu.c | 2 +-
> drivers/iommu/fsl_pamu_domain.c | 4 +-
> drivers/iommu/intel/iommu.c | 10 ++--
> drivers/iommu/intel/pasid.c | 6 ++-
> drivers/iommu/iommu.c | 22 ++++++++
> drivers/iommu/ipmmu-vmsa.c | 2 -
> drivers/iommu/msm_iommu.c | 59 +++++++++++----------
> drivers/iommu/mtk_iommu.c | 4 +-
> drivers/iommu/omap-iommu.c | 6 +--
> drivers/iommu/sprd-iommu.c | 4 +-
> drivers/iommu/tegra-gart.c | 2 +-
> drivers/iommu/virtio-iommu.c | 7 ++-

For virtio-iommu:

Reviewed-by: Jean-Philippe Brucker <jean-philippe@xxxxxxxxxx>

> include/linux/iommu.h | 12 +++++
> 17 files changed, 90 insertions(+), 83 deletions(-)
>
> --
> 2.17.1
>