RE: [PATCH] fs/efs/inode.c: use __func__ instead of function name

From: David Laight
Date: Wed Sep 21 2022 - 05:54:32 EST


From: Al Viro
> Sent: 20 September 2022 01:24
>
> On Mon, Sep 19, 2022 at 10:33:14AM +0800, Jiangshan Yi wrote:
> > From: Jiangshan Yi <yijiangshan@xxxxxxxxxx>
> >
> > It is better to use __func__ instead of function name.
>
> Why is it better? And why is it *not* sent to (active)
> maintainers of fs/erofs? I'm not going to apply that behind their
> backs and I would ask akpm to abstain from taking that one.

It is distinctly worse.
Anyone grepping the kernel source for the message text will
fail to find it.

David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)