Re: [PATCH] mm/vmscan: don't scan adjust too much if current is not kswapd

From: Hongchen Zhang
Date: Wed Sep 21 2022 - 06:14:54 EST


Hi Mel,

Thanks for your reply.

On 2022/9/21 pm 5:13, Mel Gorman wrote:
On Tue, Sep 20, 2022 at 10:23:05AM +0800, Hongchen Zhang wrote:
Hi Mel,

The scan adjust algorithm was originally introduced by you from
commmit e82e0561dae9 ("mm: vmscan: obey proportional scanning requirements
for kswapd"), any suggestion about this fix patch?
In short, proportional scanning is not friendly to processes other than
kswapd.


I suspect that 6eb90d649537 ("mm: vmscan: fix extreme overreclaim and swap
floods") is a more appropriate fix. While it also has a fairness impact,
it's a more general approach that is likely more robust and while
fairness is important, completely thrashing a full LRU is neither fair
nor expected.

OK,got it. Let's wait for the 6eb90d649537 ("mm: vmscan: fix extreme overreclaim and swap floods") enter the stable repository.

Best Regards
Hongchen Zhang