Re: [PATCH 2/2] mmc: dw_mmc-pltfm: socfpga: add method to configure clk-phase

[Ulf Hansson]

On Wed, 21 Sept 2022 at 13:13, Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> On 21/09/2022 12:31, Ulf Hansson wrote:
> >> Not in next-20220919.
> >
> > Dinh is right!
> >
> > It seems like both me and Krzysztof missed the already documented
> > binding. Probably because the property is named like below and that I
> > did "git grep clk-phase-sd" :-)
> >
> > "^clk-phase-(legacy|sd-hs|mmc-(hs|hs[24]00|ddr52)|uhs-(sdr(12|25|50|104)|ddr50))$":
>
> Too much trust in git grep. Thanks for finding it.
>
> >
> >>
> >>>
> >>> Should I create a specific documentation just for
> >>> "altr,socfpga-dw-mshc" and document "clk-phase-sd-hs"?
> >>
> >> All properties must be documented.
> >
> > Yes, but as stated above, we should be okay in this case.
> >
> >>
> >>>
> >>>>
> >>>>> +       if (rc) {
> >>>>> +               sys_mgr_base_addr =
> >>>>> +                       altr_sysmgr_regmap_lookup_by_phandle(np, "altr,sysmgr-syscon");
> >>>>
> >>>> DT bindings?
> >>>
> >>> "altr,sysmgr-syscon" has already been documented in
> >>> Documentation/devicetree/bindings/net/socfpga-dwmac.txt
> >>
> >> This is not documentation of nodes you are changing here and in patch 1.
> >>
> >> You linked altr,socfpga-stmmac and here you have altr,socfpga-dw-mshc...
> >
> > Right.
> >
> > I guess an option is to convert
> > Documentation/devicetree/bindings/net/socfpga-dwmac.txt into the yaml
> > based format and then reference that binding from
> > synopsys-dw-mshc-common.yaml?
>
> I did not look much inside, but isn't them entirely different devices
> (net vs mmc)? If they are different, then such vendor-custom property
> needs to appear in each bindings. The same as we have for other
> syscon-like properties.

I was thinking that it was a specific binding for the syscon device
that could be shared among its consumers. But it isn't.

So, you are definitely right, it seems better to have a vendor-custom
property defined in the mmc bindings for this. Thanks for your
feedback!

>
> Best regards,
> Krzysztof
>

Kind regards
Uffe