Re: [PATCH] coresight: acpi: add support for amba dma-330 controller

[Vijayenthiran Subramanian]

Hi Sudeep,

On Fri, Sep 16, 2022 at 1:06 PM Sudeep Holla <sudeep.holla@xxxxxxx> wrote:
>
> On Fri, Sep 16, 2022 at 04:49:12PM +0530, Vijayenthiran Subramaniam wrote:
> > Add ACPI ID for ARM DMA-330 controller to AMBA id list to allow the
> > probing of the device.
> >
>
> $subject pattern is simply wrong and I see this is just copied from the
> previous commit which makes no sense here. You can see other commits
> and their patterns too.
>
> Use prefix something like:
> ACPI / amba:
> or
> ACPI: amba:
>
> Also "Add .." in the $subject sounds like you are adding the support for
> the controller here which is not the case.
>
> Enable support for Arm Primecell PL330 dma controller
> Or
> Add Arm Primecell PL330 dma controller to the supported list

Ack.

I have posted v2 with the subject:
[PATCH v2] ACPI: amba: Add Arm DMA-330 controller to the supported list.

>
> --
> Regards,
> Sudeep