Re: [PATCH v3 1/1] serial: 8250: Toggle IER bits on only after irq has been set up

From: Andy Shevchenko
Date: Wed Sep 21 2022 - 11:01:16 EST


On Wed, Sep 21, 2022 at 04:20:50PM +0300, Ilpo Järvinen wrote:
> On Mon, 19 Sep 2022, Ilpo Järvinen wrote:

...

> > - retval = up->ops->setup_irq(up);
> > - if (retval)
> > - goto out;
> > + univ8250_setup_timer(up);

> Please scratch this patch. It seems to create a circular dependency issue
> with allmodconfig. I'll send v4 once the problem is sorted out.

In accordance with what you told me privately, I think you will need yet
another ops, i.e. ->setup_timer().

--
With Best Regards,
Andy Shevchenko