Re: [PATCH v2 2/3] Added Xilinx XDMA IP core driver

From: Martin Tůma
Date: Wed Sep 21 2022 - 11:39:19 EST


On 21. 09. 22 17:15, Lizhi Hou wrote:

On 9/21/22 02:25, Martin Tůma wrote:
> Currently, the V3 patch series does not support register user logic
> interrupt yet.

This is a showstopper for almost every XDMA based PCIe card. As the driver "consumes" the whole register space (including the user IRQs enable/disable registers), there is AFAIK no way how to enable the user IRQs when this driver is loaded.

> Could you convert your driver to use this?

Not without the user IRQs.

I provided the patch link for user logic IRQ support in previous reply. You may pull it and patch it on top of the V3 patch series.


Lizhi


M.

I'm sorry, I have missed that. With that modification it should be (theoretically - haven't tested it yet) possible to use our v4l2 driver with this XDMA driver instead of the one I have provided in my patches.

I will now try to rewrite our driver and test it with your XDMA driver to be sure it works. It will however definitely need a "V4" of your XDMA driver with that patch on github before it can be included into the kernel and be usable for all XDMA-based PCIe cards.

M.