Re: [PATCH v7] checkpatch: warn for non-standard fixes tag style

From: Joe Perches
Date: Wed Sep 21 2022 - 12:57:56 EST


On Wed, 2022-09-21 at 16:25 +0200, Niklas Söderlund wrote:
> Hello Joe,

Hello Niklas

> Just wanted to check on my misunderstanding below before posting a v8.

I think v7 is ok, unless you found something else better.

> > > One grep pattern to verify the non canonical fixes format that
> > > are mistakenly used is:
> > >
> > > $ git log --since=5-years-ago --no-merges --grep='^\s*fixes' -i --format=email -P | \
> > > grep -P -i '^\s*fixes' | \
> > > grep -P -v '^Fixes: [0-9a-f]{12,12}\s*\(".*")'
> > > There are many different styles.
> > > Parentheses are sometimes not used.
> >
> > I understand this, and I did have a look at it.

Good enough for me. Thanks.