RE: [Patch v5 12/12] RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter

From: Long Li
Date: Wed Sep 21 2022 - 14:52:40 EST


> Subject: Re: [Patch v5 12/12] RDMA/mana_ib: Add a driver for Microsoft
> Azure Network Adapter
>
> On Tue, Sep 20, 2022 at 05:54:19PM +0000, Dexuan Cui wrote:
>
> > > +int mana_ib_gd_create_dma_region(struct mana_ib_dev *dev, struct
> > > ib_umem *umem,
> > > + mana_handle_t *gdma_region, u64 page_sz)
> {
> > > ...
> > > +
> > > +if (!err)
> > > + return 0;
> >
> > Please add a Tab character to the above 2 lines.
>
> How are we still at the point where we have trivial style errors in this series at
> v6?? This is not OK, please handle reviews for this basic stuff internally.
>
> Jason

I'm sorry for this style error. We'll review everything.

Long