Re: [PATCH -next] IB/hfi1,PCI: Fix missing pci_disable_device() in probe and remove

From: Leon Romanovsky
Date: Thu Sep 22 2022 - 07:47:07 EST


On Thu, Sep 22, 2022 at 10:46:01AM +0800, ruanjinjie wrote:
> Replace pci_enable_device() with pcim_enable_device(),
> pci_disable_device() and pci_release_regions() will be
> called in release automatically.
>
> Signed-off-by: ruanjinjie <ruanjinjie@xxxxxxxxxx>
> ---
> drivers/infiniband/hw/hfi1/pcie.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)

This driver doesn't use devres model and manages all resources by
itself. IMHO, it is much more saner than using automatic resource
release.

Thanks