Re: [PATCH v4 11/12] KVM: mips, x86: do not rely on KVM_REQ_UNHALT

[Philippe Mathieu-Daudé]

On Wed, Sep 21, 2022 at 2:34 AM Sean Christopherson <seanjc@xxxxxxxxxx> wrote:
>
> From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
>
> KVM_REQ_UNHALT is a weird request that simply reports the value of
> kvm_arch_vcpu_runnable() on exit from kvm_vcpu_halt().  Only
> MIPS and x86 are looking at it, the others just clear it.  Check
> the state of the vCPU directly so that the request is handled
> as a nop on all architectures.
>
> No functional change intended, except for corner cases where an
> event arrive immediately after a signal become pending or after
> another similar host-side event.
>
> Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> Signed-off-by: Sean Christopherson <seanjc@xxxxxxxxxx>
> ---
>  arch/mips/kvm/emulate.c | 7 +++----
>  arch/x86/kvm/x86.c      | 9 ++++++++-
>  2 files changed, 11 insertions(+), 5 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@xxxxxxxxx>