Re: [PATCH v4 1/7] scsi: libsas: Add sas_ata_device_link_abort()

[Jason Yan]

On 2022/9/22 17:46, John Garry wrote:
> Similar to how AHCI handles NCQ errors in ahci_error_intr() ->
> ata_port_abort() -> ata_do_link_abort(), add an NCQ error handler for LLDDs
> to call to initiate a link abort.
>
> This will mark all outstanding QCs as failed and kick-off EH.
>
> Note:
> A "force reset" argument is added for drivers which require the ATA error
> handling to always reset the device.
>
> A driver may require this feature for when SATA device per-SCSI cmnd
> resources are only released during reset for ATA EH. As such, we need an
> option to force reset to be done, regardless of what any EH autopsy
> decides.
>
> Suggested-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: John Garry <john.garry@xxxxxxxxxx>
> Tested-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>
> ---
>   drivers/scsi/libsas/sas_ata.c | 12 ++++++++++++
>   include/scsi/sas_ata.h        |  6 ++++++
>   2 files changed, 18 insertions(+)

Reviewed-by: Jason Yan <yanaijie@xxxxxxxxxx>