Re: [PATCH] ASoC: mediatek: mt8195-mt6359: Use snd_soc_pm_ops instead of custom ops

From: AngeloGioacchino Del Regno
Date: Thu Sep 22 2022 - 10:11:26 EST


Il 22/09/22 15:30, Mark Brown ha scritto:
On Thu, Sep 22, 2022 at 07:26:21PM +0800, Tzung-Bi Shih wrote:

snd_soc_pm_ops[1] sets some more fields. I'm not quite sure whether
it would introduce any side effect or not. Perhaps Trevor could
provide some suggestions.

If it does it should be to fix isues rather than introduce new
problems - I suspect the other operations just don't work
currently.

From my upstream tests, this didn't introduce any issues, that's why I've
sent this patch.

In any case, let's check with Trevor, just as to be extremely sure, but please
use an upstream kernel for eventual tests, as there are quite a bit of changes
between 5.10 and current upstream.

Cheers,
Angelo