Re: [PATCH v2 char-misc-next] misc: microchip: pci1xxxx: use DEFINE_SIMPLE_DEV_PM_OPS() in place of the SIMPLE_DEV_PM_OPS() in pci1xxxx's gpio driver

From: Greg KH
Date: Thu Sep 22 2022 - 10:54:02 EST


On Wed, Sep 21, 2022 at 05:48:45PM +0100, Conor Dooley wrote:
> On Thu, Sep 15, 2022 at 03:17:29PM +0530, Kumaravel Thiagarajan wrote:
> > misc: microchip: pci1xxxx: use DEFINE_SIMPLE_DEV_PM_OPS() in place of the SIMPLE_DEV_PM_OPS() in pci1xxxx's gpio driver
> ^^
> FYI, double space in the subject here, rather a mouthful though and
> surely everything after SIMPLE_DEV_PM_OPS() is redundant?
>
> > build errors listed below and reported by Sudip Mukherjee
> > <sudipm.mukherjee@xxxxxxxxx> for the builds of
> > riscv, s390, csky, alpha and loongarch allmodconfig are fixed in
> > this patch.
>
> allmodconfig has been broken for a while now, and this patch appears
> to have been sitting for a week & a second fix has shown up at:
> https://lore.kernel.org/all/20220919094250.858716-1-zengheng4@xxxxxxxxxx/
>
> I do note that Zeng Hang's patch does slightly more than this one does,
> but idk about about the PM APIs /shrug.
>
> Has this just slipped under the radar since so many of us were
> attending conferences etc the last while or are you looking for
> Kumaravel to do something more here?

I've taken this change now, sorry for the delay. Was not looking at
patches while at conferences.

greg k-h