Re: [PATCH v2 2/3] ARM: dts: orion5x: Add D-Link DNS-323 Device Tree

From: Andrew Lunn
Date: Thu Sep 22 2022 - 16:46:04 EST


> + chosen {
> + stdout-path = "serial0:115200n8";
> + bootargs = "console=ttyS0,115200n8 earlyprintk";

bootargs is generally not liked. Since you have stdout-path do you
need console=ttyS0,115200n8? earlyprintk should not be needed now you
have something which boots.

> +&mdio {
> + status = "okay";
> +
> + ethphy: ethernet-phy {
> + reg = <8>;

Since you have a reg value, this should be ethernet-phy@9

Andrew