Re: [PATCH v5 6/6] iommu: Propagate return value in ->attach_dev callback functions

From: Yong Wu
Date: Thu Sep 22 2022 - 21:10:24 EST


On Thu, 2022-09-22 at 01:54 -0700, Nicolin Chen wrote:
> The mtk_iommu and virtio drivers have places in the ->attach_dev
> callback
> functions that return hardcode errnos instead of the returned values,
> but
> callers of these ->attach_dv callback functions may care. Propagate
> them
> directly without the extra conversions.
>
> Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>
> Reviewed-by: Jean-Philippe Brucker <jean-philippe@xxxxxxxxxx>
> Signed-off-by: Nicolin Chen <nicolinc@xxxxxxxxxx>
> ---
> drivers/iommu/mtk_iommu.c | 2 +-
> drivers/iommu/virtio-iommu.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>

Reviewed-by: Yong Wu <yong.wu@xxxxxxxxxxxx> #For mtk_iommu.c

Thanks.