Re: [PATCH net-next 2/2] net: hns3: PF add support setting parameters of congestion control algorithm by devlink param

From: Jakub Kicinski
Date: Thu Sep 22 2022 - 22:23:24 EST


On Fri, 23 Sep 2022 09:38:18 +0800 Guangbin Huang wrote:
> Some new devices support dynamiclly configuring parameters of congestion
> control algorithm, this patch implement it by devlink param.
>
> Examples of read and set command are as follows:
>
> $ devlink dev param set pci/0000:35:00.0 name algo_param value \
> "type@dcqcn_alp@30_f@35_tmp@11_tkp@11_ai@60_maxspeed@17_g@11_al@19_cnptime@20" \
> cmode runtime
>
> $ devlink dev param show pci/0000:35:00.0 name algo_param
> pci/0000:35:00.0:
> name algo_param type driver-specific
> values:
> cmode runtime value type@dcqcn_ai@60_f@35_tkp@11_tmp@11_alp@30_maxspeed@17_g@11_al@19_cnptime@20

Please put your RDMA params to the RDMA subsystem.
It's not what devlink is for. In general 95% of the time devlink params
are not the answer upstream.