Re: [PATCH v4 25/25] tracing/rseq: Add mm_vcpu_id field to rseq_update
From: kernel test robot
Date: Fri Sep 23 2022 - 05:56:04 EST
Hi Mathieu,
I love your patch! Yet something to improve:
[auto build test ERROR on rostedt-trace/for-next]
[cannot apply to shuah-kselftest/next tip/sched/core kees/for-next/execve linus/master v6.0-rc6 next-20220921]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Mathieu-Desnoyers/RSEQ-node-id-and-virtual-cpu-id-extensions/20220922-191315
base: https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git for-next
config: x86_64-randconfig-a001 (https://download.01.org/0day-ci/archive/20220923/202209231723.5HqjA1Iy-lkp@xxxxxxxxx/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/1e36316a4b14e773e904e677149f9f757057fd90
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Mathieu-Desnoyers/RSEQ-node-id-and-virtual-cpu-id-extensions/20220922-191315
git checkout 1e36316a4b14e773e904e677149f9f757057fd90
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
In file included from kernel/rseq.c:19:
In file included from include/trace/events/rseq.h:62:
In file included from include/trace/define_trace.h:102:
In file included from include/trace/trace_events.h:419:
>> include/trace/events/rseq.h:26:28: error: no member named 'mm_vcpu' in 'struct task_struct'
__entry->mm_vcpu_id = t->mm_vcpu;
~ ^
include/trace/stages/stage6_event_callback.h:112:33: note: expanded from macro 'TP_fast_assign'
#define TP_fast_assign(args...) args
^~~~
include/trace/trace_events.h:44:16: note: expanded from macro 'TRACE_EVENT'
PARAMS(assign), \
^~~~~~
include/linux/tracepoint.h:107:25: note: expanded from macro 'PARAMS'
#define PARAMS(args...) args
^~~~
include/trace/trace_events.h:402:4: note: expanded from macro 'DECLARE_EVENT_CLASS'
{ assign; } \
^~~~~~
In file included from kernel/rseq.c:19:
In file included from include/trace/events/rseq.h:62:
In file included from include/trace/define_trace.h:103:
In file included from include/trace/perf.h:113:
>> include/trace/events/rseq.h:26:28: error: no member named 'mm_vcpu' in 'struct task_struct'
__entry->mm_vcpu_id = t->mm_vcpu;
~ ^
include/trace/stages/stage6_event_callback.h:112:33: note: expanded from macro 'TP_fast_assign'
#define TP_fast_assign(args...) args
^~~~
include/trace/trace_events.h:44:16: note: expanded from macro 'TRACE_EVENT'
PARAMS(assign), \
^~~~~~
include/linux/tracepoint.h:107:25: note: expanded from macro 'PARAMS'
#define PARAMS(args...) args
^~~~
include/trace/perf.h:89:4: note: expanded from macro 'DECLARE_EVENT_CLASS'
{ assign; } \
^~~~~~
2 errors generated.
vim +26 include/trace/events/rseq.h
12
13 TP_PROTO(struct task_struct *t),
14
15 TP_ARGS(t),
16
17 TP_STRUCT__entry(
18 __field(s32, cpu_id)
19 __field(s32, node_id)
20 __field(s32, mm_vcpu_id)
21 ),
22
23 TP_fast_assign(
24 __entry->cpu_id = raw_smp_processor_id();
25 __entry->node_id = cpu_to_node(raw_smp_processor_id());
> 26 __entry->mm_vcpu_id = t->mm_vcpu;
27 ),
28
29 TP_printk("cpu_id=%d node_id=%d mm_vcpu_id=%d", __entry->cpu_id,
30 __entry->node_id, __entry->mm_vcpu_id)
31 );
32
--
0-DAY CI Kernel Test Service
https://01.org/lkp