Re: [PATCH v1 1/1] gpio: tegra: Convert to immutable irq chip
From: kernel test robot
Date: Fri Sep 23 2022 - 06:17:55 EST
Hi Svyatoslav,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on tegra/for-next]
[also build test ERROR on brgl/gpio/for-next tegra-drm/drm/tegra/for-next linus/master v6.0-rc6 next-20220921]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Svyatoslav-Ryhel/gpio-tegra-Convert-to-immutable-irq-chip/20220922-180544
base: https://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git for-next
config: arm64-randconfig-r013-20220922 (https://download.01.org/0day-ci/archive/20220923/202209231809.KsxZvnZk-lkp@xxxxxxxxx/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 791a7ae1ba3efd6bca96338e10ffde557ba83920)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/11723f8236100feb12775c232d66668969dde7fc
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Svyatoslav-Ryhel/gpio-tegra-Convert-to-immutable-irq-chip/20220922-180544
git checkout 11723f8236100feb12775c232d66668969dde7fc
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/gpio/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
>> drivers/gpio/gpio-tegra.c:616:32: error: use of undeclared identifier 'tegra_gpio_irq_set_wake'; did you mean 'tegra_gpio_irq_set_type'?
.irq_set_wake = pm_sleep_ptr(tegra_gpio_irq_set_wake),
^~~~~~~~~~~~~~~~~~~~~~~
tegra_gpio_irq_set_type
include/linux/pm.h:439:65: note: expanded from macro 'pm_sleep_ptr'
#define pm_sleep_ptr(_ptr) PTR_IF(IS_ENABLED(CONFIG_PM_SLEEP), (_ptr))
^
include/linux/kernel.h:57:38: note: expanded from macro 'PTR_IF'
#define PTR_IF(cond, ptr) ((cond) ? (ptr) : NULL)
^
drivers/gpio/gpio-tegra.c:304:12: note: 'tegra_gpio_irq_set_type' declared here
static int tegra_gpio_irq_set_type(struct irq_data *d, unsigned int type)
^
drivers/gpio/gpio-tegra.c:630:32: error: use of undeclared identifier 'tegra_gpio_irq_set_wake'; did you mean 'tegra_gpio_irq_set_type'?
.irq_set_wake = pm_sleep_ptr(tegra_gpio_irq_set_wake),
^~~~~~~~~~~~~~~~~~~~~~~
tegra_gpio_irq_set_type
include/linux/pm.h:439:65: note: expanded from macro 'pm_sleep_ptr'
#define pm_sleep_ptr(_ptr) PTR_IF(IS_ENABLED(CONFIG_PM_SLEEP), (_ptr))
^
include/linux/kernel.h:57:38: note: expanded from macro 'PTR_IF'
#define PTR_IF(cond, ptr) ((cond) ? (ptr) : NULL)
^
drivers/gpio/gpio-tegra.c:304:12: note: 'tegra_gpio_irq_set_type' declared here
static int tegra_gpio_irq_set_type(struct irq_data *d, unsigned int type)
^
2 errors generated.
vim +616 drivers/gpio/gpio-tegra.c
609
610 static const struct irq_chip tegra_gpio_irq_chip = {
611 .irq_shutdown = tegra_gpio_irq_shutdown,
612 .irq_ack = tegra_gpio_irq_ack,
613 .irq_mask = tegra_gpio_irq_mask,
614 .irq_unmask = tegra_gpio_irq_unmask,
615 .irq_set_type = tegra_gpio_irq_set_type,
> 616 .irq_set_wake = pm_sleep_ptr(tegra_gpio_irq_set_wake),
617 .irq_print_chip = tegra_gpio_irq_print_chip,
618 .irq_request_resources = tegra_gpio_irq_request_resources,
619 .irq_release_resources = tegra_gpio_irq_release_resources,
620 .flags = IRQCHIP_IMMUTABLE,
621 };
622
--
0-DAY CI Kernel Test Service
https://01.org/lkp