build failure of next-20220923 due to f6f6f9a01374 ("thermal/intel/int340x: Replace parameter to simplify")

[Sudip Mukherjee (Codethink)]

Hi All,

The builds of x86_64 allmodconfig with clang failed to build next-20220923
with the error:

drivers/thermal/intel/int340x_thermal/int340x_thermal_zone.c:222:6: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
        if (!int34x_thermal_zone->ops)
            ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/thermal/intel/int340x_thermal/int340x_thermal_zone.c:279:17: note: uninitialized use occurs here
        return ERR_PTR(ret);
                       ^~~
drivers/thermal/intel/int340x_thermal/int340x_thermal_zone.c:222:2: note: remove the 'if' if its condition is always false
        if (!int34x_thermal_zone->ops)
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/thermal/intel/int340x_thermal/int340x_thermal_zone.c:211:9: note: initialize the variable 'ret' to silence this warning
        int ret;
               ^
                = 0
1 error generated.

git bisect pointed to f6f6f9a01374 ("thermal/intel/int340x: Replace parameter to simplify").

I will be happy to test any patch or provide any extra log if needed.


-- 
Regards
Sudip