Re: [PATCH] dt-bindings: usb: dwc3: Add interrupt-names to include hibernation interrupt

[Michal Simek]

Hi Felipe,

On 9/23/22 14:43, Felipe Balbi wrote:
> Hi,
>
> Piyush Mehta <piyush.mehta@xxxxxxx> writes:
> > From: Manish Narani <manish.narani@xxxxxxxxxx>
> >
> > The hibernation feature enabled for Xilinx ZynqMP SoC in DWC3 IP.
> > Added the below interrupt-names in the binding schema for the same.
> >
> > dwc_usb3: dwc3 core interrupt-names
> > otg: otg interrupt-names
> > hiber: hibernation interrupt-names
> >
> > Signed-off-by: Manish Narani <manish.narani@xxxxxxxxxx>
> > Signed-off-by: Piyush Mehta <piyush.mehta@xxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> > index 1779d08ba1c0..618fa7bd32be 100644
> > --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> > +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> > @@ -53,6 +53,8 @@ properties:
> >         - const: dwc_usb3
> >         - items:
> >             enum: [host, peripheral, otg]
> > +      - items:
> > +          enum: [dwc_usb3, otg, hiber]
>
> I would spell it out; i.e. `hibernation' instead of `hiber'.

that wouldn't be an issue. What about that wake-up line?

Thanks,
Michal