Re: [PATCH v4 i2c-master] i2c: microchip: pci1xxxx: Add driver for I2C host controller in multifunction endpoint of pci1xxxx switch

[Tharunkumar.Pasumarthi]

On Sat, 2022-09-17 at 23:01 +0200, Wolfram Sang wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> If you can't do I2C_FUNC_SMBUS_QUICK, then you need an i2c_adapter_quirk
> struct saying that your HW cannot do 0 byte length transfers.
>
> Also, a lot can be simplified here, e.g. I2C_FUNC_SMBUS_BYTE covers both
> cases, read and write.

Okay. I will update code.

> Why not use then simply 0 instead of a define and a comment?

Okay, I will update.

> I need to make sure: do you intentionally want autoprobing for SPD? I
> ask because it could be needed but it costs boottime when not needed.
> And changing the class once exposed is troublesome.

Autoprobing is not required. I can modify code. 

All these comments need to be addressed now or can be fixed later after the
patch is applied?


Thanks,
Tharun Kumar P