RE: [PATCH v2 3/3] dmaengine: tegra: Add support for dma-channel-mask

[Akhil R]

> >> Ah OK. I was wondering how this worked with 'channel_reg_size' but
> >> looking closer I see channel_reg_size is always SZ_64K. I wonder why we
> >> even bother having this parameter and don't use SZ_64K directly?
> > There is an offset from the base address which the per channel registers start.
> > Although this offset value happens to match with the channel_reg_size, this is
> > not actually the per channel register size.
> 
> Yes I see that, but I mean why do we even bother having this
> channel_reg_size parameter? Does not look like we need this (currently).
> All we need is ...
> 
>   tdc->chan_base_offset = TEGRA_GPCDMA_CHANNEL_BASE_ADDR_OFFSET +
>                           (i * SZ_64K);
> 
Ah. Ok. Got it now. Would add this as an improvement in another patch.

Thanks,
Akhil