RE: [PATCH v6 5/8] EDAC/ghes: Make ghes_edac a proper module to remove the dependency on ghes

[Justin He]

Hi Borislav

> -----Original Message-----
> From: Borislav Petkov <bp@xxxxxxxxx>
> Sent: Friday, September 23, 2022 11:43 PM
> To: Justin He <Justin.He@xxxxxxx>
> Cc: Len Brown <lenb@xxxxxxxxxx>; James Morse <James.Morse@xxxxxxx>;
> Tony Luck <tony.luck@xxxxxxxxx>; Mauro Carvalho Chehab
> <mchehab@xxxxxxxxxx>; Robert Richter <rric@xxxxxxxxxx>; Robert Moore
> <robert.moore@xxxxxxxxx>; Qiuxu Zhuo <qiuxu.zhuo@xxxxxxxxx>; Yazen
> Ghannam <yazen.ghannam@xxxxxxx>; Jan Luebbe <jlu@xxxxxxxxxxxxxx>;
> Khuong Dinh <khuong@xxxxxxxxxxxxxxxxxxxxxx>; Kani Toshi
> <toshi.kani@xxxxxxx>; Ard Biesheuvel <ardb@xxxxxxxxxx>;
> linux-acpi@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> linux-edac@xxxxxxxxxxxxxxx; devel@xxxxxxxxxx; Rafael J . Wysocki
> <rafael@xxxxxxxxxx>; Shuai Xue <xueshuai@xxxxxxxxxxxxxxxxx>; Jarkko
> Sakkinen <jarkko@xxxxxxxxxx>; linux-efi@xxxxxxxxxxxxxxx; nd <nd@xxxxxxx>
> Subject: Re: [PATCH v6 5/8] EDAC/ghes: Make ghes_edac a proper module to
> remove the dependency on ghes
> 
> On Thu, Sep 22, 2022 at 08:26:16AM +0000, Justin He wrote:
> > If there is no ghes_present flag.
> > What if ghes.disable is passed to kernel boot parameter and then
> > ghes_edac is loaded by modprobe?
> > Thus, ghes_edac can be loaded even if ghes is disabled. (ghes_dev list
> > is null)
> 
> Yes, and what happens if ghes_dev is NULL?
> 
Okay, I am fine if it is allowed to register ghes_dev with
> The other drivers would do in their init function:
> 
> 	struct list_head *ghes_devs;
> 
> 	ghes_devs = ghes_get_devices();
> 	if (ghes_devs)
> 		return -ENODEV;
> 
> 	/* Continue init */
> 
> and then load in that case because user has disabled GHES and thus no
> ghes_edac either. So the platform-specific one loads.

Okay, I am fine with removing ghes_present and ghes_edac_preferred if
It is ok to register empty ghes_dev list without prompting an error 


--
Cheers,
Justin (Jia He)